[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: ACL check parameters

masarati@aero.polimi.it wrote:
>> Hallvard B Furuseth wrote:
>>> Howard Chu writes:
>>>> oprofile shows quite a bit more overhead in 2.4's ACL processing vs
>>>> 2.3's. I'm thinking of streamlining things a bit, along these lines.
>>>> Any thoughts?
>>> Only a few loose ones:
>>> A brief look shows some deep indirection, which may be harder for
>>> compilers to optimize due to possible aliasing among intervening writes.
>>> Maybe you should help by unpacking some more common expressions into
>>> local variables.
>> Profiling showed that the ACLCHECK branch didn't have any improvement over
>> HEAD. Looks like it may not be worth the trouble.
> Are you going to drop this?

Yes, doesn't seem to offer any real benefit. If you can think of some other
reason to keep it, we can perhaps talk about how to make it viable.

  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/