[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: ACL Performance (caching on object basis) (ITS#1523)

I've looked thru it, there are still some details that could be
cleaned up. I think this code does too much work if all you want
is to speed up send_search_entry, and there is a simpler way to
accomplish that, as Kurt has described in previous posts.

As far as individual details: there is no need to pass ACLCache ** to
access_allowed, it would be better if it were just ACLCache * and would
save one indirection and NULL test. The ACLCache itself can be a local
structure, no need to malloc it. The individual list elements would still
be malloced and managed as before.

That's what I see at the moment, will wait to hear from others...

  -- Howard Chu
  Chief Architect, Symas Corp.       Director, Highland Sun
  http://www.symas.com               http://highlandsun.com/hyc  
  Symas: Premier OpenSource Development and Support

> -----Original Message-----
> From: masarati@carnelian.propagation.net
> [mailto:masarati@carnelian.propagation.net]On Behalf Of Pierangelo
> Masarati
> Stephan Siano wrote:
> > 
> > Hi,
> > I just uploaded the updated version of the patch to
> > ftp://ftp.openldap.org/incoming/stephan-siano-20020201.patch, however it
> > seems that I'm not able (not permitted or to dumb) to update the ITS.
> You need to authenticate first (and you also need an account :)
> You should reply to openldap-its@openldap.org with ITS#1523 in 
> the subject to have your message appended to the followups.
> I'll look at the patch soon; pretty sure Howard will do the same even 
> earlier :)
> Pierangelo.
> -- 
> Dr. Pierangelo Masarati               | voice: +39 02 2399 8309
> Dip. Ing. Aerospaziale                | fax:   +39 02 2399 8334
> Politecnico di Milano                 |
> mailto:pierangelo.masarati@polimi.it
> via La Masa 34, 20156 Milano, Italy   |
> http://www.aero.polimi.it/~masarati