[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: commit: ldap/servers/slapd/back-bdb modify.c

Thanks, that looks fine.

This code is going to need some more changing, or perhaps reverting to the
previous approach. As Kurt pointed out to me, we can't delete keys from the
index based on a single value, because the index generation code tends to
generate duplicate keys for a large set of input. E.g., a substring index on
an attribute foo with values
will have a duplicate key on the "ef" substring. With the current code, if
you delete the attribute foo=efghi, then the key for "ef" will disappear,
which will wrongly cause the value foo=bcdef to disappear from substring


  -- Howard Chu
  Chief Architect, Symas Corp.       Director, Highland Sun
  http://www.symas.com               http://highlandsun.com/hyc
  Symas: Premier OpenSource Development and Support

> -----Original Message-----
> From: owner-openldap-commit@OpenLDAP.org
> [mailto:owner-openldap-commit@OpenLDAP.org]On Behalf Of
> lukeh@OpenLDAP.org
> Sent: Tuesday, May 13, 2003 10:25 PM
> To: OpenLDAP Commit
> Subject: commit: ldap/servers/slapd/back-bdb modify.c
> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/back-bdb
> Modified Files:
> 	modify.c  1.74 -> 1.75
> Log Message:
> Don't crash if attr_find() fails (Howard, you might like to
> review this)
> CVS Web URLs:
>   http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bdb/
> http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/back-bd
> b/modify.c
> Changes are generally available on cvs.openldap.org (and CVSweb)
> within 30 minutes of being committed.