Full_Name: Hallvard B Furuseth Version: HEAD, RE23, RE24 OS: URL: Submission from: (NULL) (129.240.6.233) Submitted by: hallvard Some slapd source files include libldap/ldap-int.h, which contains #ifdef LDAP_R_COMPILE in structs. slapd links libldap_r but does not define LDAP_R_COMPILE, so these files have access to bad struct definitions. A quick grep doesn't show any use cases though. Anyway: Either #ifdef LDAP_R_COMPILE in libldap(_r)should be something else, or we should define LDAP_R_COMPILE in slapd - maybe like this: --- slap.h 13 Mar 2008 13:37:07 +++ slap.h 13 Mar 2008 16:40:25 @@ -28,4 +28,10 @@ #define _SLAP_H_ +#if defined _LDAP_INT_H +# error include slap.h before ldap-int.h +#elif !defined NO_THREADS +# define LDAP_R_COMPILE 1 +#endif + #include "ldap_defaults.h"
moved from Incoming to Development
changed notes
Taken to this thread: http://www.openldap.org/lists/openldap-devel/201011/msg00013.html librewrite & co vs. logging & ldap-int.h Since this ITS now depends on the ldap_debug hack in ldap_log.h, I'm removing some unnecessary '#include <ldap_log.h>'s for clarity. -- Hallvard
changed notes changed state Open to Partial
changed notes changed state Partial to Test
h.b.furuseth@usit.uio.no wrote: > Taken to this thread: > > http://www.openldap.org/lists/openldap-devel/201011/msg00013.html > librewrite& co vs. logging& ldap-int.h > > Since this ITS now depends on the ldap_debug hack in ldap_log.h, > I'm removing some unnecessary '#include<ldap_log.h>'s for clarity. > I've committed the fix suggested in the email linked above. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
changed notes changed state Test to Release
changed notes changed state Release to Closed
See openldap-devel "librewrite & co vs. logging & ldap-int.h", nov 2010 fixed in HEAD some work done in RE24