[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Kill K&R C support?

On Jun 14, 2007, at 9:44 AM, Hallvard B Furuseth wrote:

As far as I can tell, OpenLDAP has been unusable with K&R C since
openldap-2.0:  lber.h in that release had prototypes unprotected
by LDAP_P() in struct sockbuf_io.  They've been there ever since.
So LDAP_P() can go.

I note that the intent was to allow use of -lldap/-llber in K&R C programs, but to require ISO C to build OpenLDAP Software.

Seems the former is broken (lber.h issues).

Don't know which other not-strict-ISO support is still useful -
I note lber.h has used <string.h> since openldap-2.2.4, for example.
libldap/open.c has used <limits.h> since 2.0.0.

The latter isn't a problem with regard to the above intent.

HEAD wraps that
in HAVE_LIMITS_H, but it does not protect INT_MAX the same way.


-- Regards, Hallvard