Re: commit: ldap/servers/slapd result.c

[Howard Chu <hyc@symas.com>]

ando@OpenLDAP.org wrote:
> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
>
> Modified Files:
> 	result.c  1.288 -> 1.289
>
> Log Message:
> allow overlays to inject an abandon without returning SLAPD_ABANDON
>
> CVS Web URLs:
>   http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/
>     http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/result.c
>
> Changes are generally available on cvs.openldap.org (and CVSweb)
> within 30 minutes of being committed.
>
> .
>
>   
I think this patch is wrong. The fact that op->o_abandon is set only 
means that an Abandon was requested, but it doesn't mean that it was 
honored. E.g., a client could have sent an Abandon for an active Modify, 
but the Modify was completed.

I suppose from the client side there may not be any way to distinguish 
meaningfully in those situations, but still this patch seems incorrect.

--
 -- Howard Chu
 Chief Architect, Symas Corp.  http://www.symas.com
 Director, Highland Sun        http://highlandsun.com/hyc
 OpenLDAP Core Team            http://www.openldap.org/project/