[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: o_private (Was: (ITS#4184) Lockup when moding one particular entry)



Pierangelo Masarati wrote:
Howard,

here's a patch that seems to implement something a bit more reliable in
terms of stacking private data on an operation.


<http://www.sys-net.it/~ando/Download/o_private.patch.bz2>

I tried to put in place something that can work either with static or
dynamic data, and that allows catching inconsistent situations like push
w/o pop.

I removed some of the (mis?)uses of o_private, like in add, in a
different manner.  I haven't completed back-sql and syncprov yet.

If you like it, I'll commit it.


Yes, it looks good to me.

Are you convinced that push/pop is sufficient, will there ever be an out-of-order access?

--
 -- Howard Chu
 Chief Architect, Symas Corp.  http://www.symas.com
 Director, Highland Sun        http://highlandsun.com/hyc
 OpenLDAP Core Team            http://www.openldap.org/project/