[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/tests/scripts defines.sh

On Sun, 2005-10-02 at 00:19 +0200, Hallvard B Furuseth wrote:
> ando@OpenLDAP.org writes:
> > Modified Files:
> > 	defines.sh  1.129 -> 1.130
> > allow writable dirs to be user-relocated
> > -DATADIR=./testdata
> >  PROGDIR=./progs
> > -TESTDIR=./testrun
> > -SCHEMADIR=./schema
> > +DATADIR=${USER_DATADIR-./testdata}
> > +TESTDIR=${USER_TESTDIR-./testrun}
> Looks inconvenient to have to pass all three to "make test".
> I suggest moving them into a common directory.
> Or since they are now only used via a variable anyway, drop the
> schema and testdata symlinks and use the directories they now
> point at directly.
> Also, the similarity between the names USER_DATADIR and USERDATA
> (in run.in) is a bit unfortunate.  It looks like run does not need
> to export USERDATA though.  Apparently only run itself uses it.

Any suggestion (and modification) is welcome.  I just committed that to
point out that we need all directories that ever get written to be
definable by the user (the link to schema only gets created, no write,
but that's enough to require a user-defined value).  Please feel free to
modify anything according to your design.


    SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497