[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/tests/scripts defines.sh

ando@OpenLDAP.org writes:
> Modified Files:
> 	defines.sh  1.129 -> 1.130
> allow writable dirs to be user-relocated

> -DATADIR=./testdata
>  PROGDIR=./progs
> -TESTDIR=./testrun
> -SCHEMADIR=./schema
> +DATADIR=${USER_DATADIR-./testdata}
> +TESTDIR=${USER_TESTDIR-./testrun}

Looks inconvenient to have to pass all three to "make test".

I suggest moving them into a common directory.
Or since they are now only used via a variable anyway, drop the
schema and testdata symlinks and use the directories they now
point at directly.

Also, the similarity between the names USER_DATADIR and USERDATA
(in run.in) is a bit unfortunate.  It looks like run does not need
to export USERDATA though.  Apparently only run itself uses it.