[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd backend.c controls.c

To: Pierangelo Masarati <ando@sys-net.it>
Subject: Re: commit: ldap/servers/slapd backend.c controls.c
From: Howard Chu <hyc@symas.com>
Date: Wed, 26 Jan 2005 12:52:23 -0800
Cc: "Kurt D. Zeilenga" <Kurt@OpenLDAP.org>, OpenLDAP Commit <openldap-commit2devel@OpenLDAP.org>
In-reply-to: <41F800A3.1090606@sys-net.it>
References: <200501251730.j0PHUtUT009760@cantor.openldap.org> <41F763B3.4030305@sys-net.it> <6.2.0.14.0.20050126104735.028378b8@mail.openldap.org> <41F800A3.1090606@sys-net.it>
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041101

Pierangelo Masarati wrote:

Comment to Howard: maybe the be/bi_controls could be turned in an array of bits much like the op_ctrlflag that is set to 1 when the control is supported and 0 otherwise, so as long as the OID is looked up once we can rather efficiently check for its availability/appropriateness. As soon as supported controls grow, linearly checking a list of strings doesn't sound much like a good approach; at least move it to bervals?

Yes, good point. Since we have CIDs available, we should use them wherever controls need to be looked up.

--
 -- Howard Chu
 Chief Architect, Symas Corp.       Director, Highland Sun
 http://www.symas.com               http://highlandsun.com/hyc
 Symas: Premier OpenSource Development and Support

References:
- Re: commit: ldap/servers/slapd backend.c controls.c
  - From: Pierangelo Masarati <ando@sys-net.it>
- Re: commit: ldap/servers/slapd backend.c controls.c
  - From: "Kurt D. Zeilenga" <Kurt@OpenLDAP.org>
- Re: commit: ldap/servers/slapd backend.c controls.c
  - From: Pierangelo Masarati <ando@sys-net.it>

Prev by Date: Re: commit: ldap/servers/slapd backend.c controls.c
Next by Date: Re: commit: ldap/servers/slapd backend.c controls.c
Index(es):
- Chronological
- Thread