Re: (ITS#8890) Bug fix patches unbreaking the build on x32 systems

[hyc@symas.com]

Thorsten Glaser wrote:
> Howard Chu dixit:
>=20
>> This patch of yours *introduces a bug*. If you wanted to actually *fix=
*
>> something you should have made sure the malloc'd buffer - which only h=
appens
>> 2 lines above the lines you change - was large enough to store a long =
long.
>=20
> That=E2=80=99s not a new bug, then.

> That=E2=80=99s a completely separate Y2038 issue of *yours* that
> will happen on all platforms, and has nothing to do with
> long vs. long long, since a long on an LP64 platform *is*
> already as wide as a long long.

Thanks to the wonderful geniuses at Microsoft, not all the world
uses LP64. IL32 is a thing. And this code works on those platforms.
Far more machines than have ever or ever will run X32. If you want
patches for your obscure system adopted, you have to make sure not
to break anything else.

> In addition to that, use of snprintf will prevent this
> from being worse than a mere truncation.

If you're going to submit a patch, submit a correct one. It's that simple=
.
If you refuse to do that, then go away.

--=20
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/