[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8890) Bug fix patches unbreaking the build on x32 systems



Howard Chu dixit:

>This patch of yours *introduces a bug*. If you wanted to actually *fix*
>something you should have made sure the malloc'd buffer - which only happe=
ns
>2 lines above the lines you change - was large enough to store a long long=
=2E

That=E2=80=99s not a new bug, then.

That=E2=80=99s a completely separate Y2038 issue of *yours* that
will happen on all platforms, and has nothing to do with
long vs. long long, since a long on an LP64 platform *is*
already as wide as a long long.

In addition to that, use of snprintf will prevent this
from being worse than a mere truncation.

bye,
//mirabilos
--=20
Solange man keine schmutzigen Tricks macht, und ich meine *wirklich*
schmutzige Tricks, wie bei einer doppelt verketteten Liste beide
Pointer XORen und in nur einem Word speichern, funktioniert Boehm ganz
hervorragend.=09=09-- Andreas Bogk =C3=BCber boehm-gc in d.a.s.r