[Date Prev][Date Next]
(ITS#8230) [PATCH] totp: bug fixes and improvements
- To: openldap-its@OpenLDAP.org
- Subject: (ITS#8230) [PATCH] totp: bug fixes and improvements
- From: email@example.com
- Date: Sat, 29 Aug 2015 14:10:53 +0000
- Auto-submitted: auto-generated (OpenLDAP-ITS)
Full_Name: Peter Marschall
Submission from: (NULL) (188.8.131.52)
I have written some bugfixes & flexibilizations for the TOTP contrib module.
You can find them in the github branch:
It differs from today's master by these commits:
contrib/passwd/totp: flexibilize decoding key
In function totp_b32_pton()
- allow lowercase characters in encoded string too
- allow padding to be omitted (totally, not only parts)
In function chk_totp() determine the space required to hold the decoded
key by calling totp_b32_pton() with a NULL argument for the target.
contrib/passwd/totp: fix the big-endian case
For the big-endian case, 'msg' wasn't set from 'tval' in generate().
contrib/passwd/totp: fix decoding when padding is used
In totp_b32_pton(), correctly count the number of '=' padding chars
at the end of the base-32 encoded string.
Note: '*str++' evaluates *str first and increases str later!
contrib/passwd/totp: support compiling using nettle
that change the file
contrib/slapd-modules/passwd/totp/slapd-totp.c | 67
I'd appreciate if you include them into OpenLDAP.
The referenced patch files are derived from OpenLDAP Software.
All of the modifications to OpenLDAP Software represented in the following
patch(es) were developedy y Peter Marschall <firstname.lastname@example.org>.
I have not assigned rights and/or interest in this work to any party.
The referenced modifications to OpenLDAP Software are subject to the following
Copyright 2015 Peter Marschall
Redistribution and use in source and binary forms, with or without
are permitted only as authorized by the OpenLDAP Public License.
Thanks in advance