[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8192) liblmdb confuses Windows error code with errno values

h.b.furuseth@usit.uio.no wrote:
> On 08/07/15 20:29, h.b.furuseth@usit.uio.no wrote:
>> Finally, I suggest we replace the explicit EIO/ENOSPC returns
>> with either a new MDB code or #define MDB_EIO EIO on Unix
>> and something else on Windows.
> I mean, without waiting for LMDB-1.*.  They are fairly
> obscure errors, I doubt anyone is testing for them.

When there is a platform-specific error code that describes the situation, we 
should use it. In particular, if the error code comes from an underlying 
system call and accurately describes that failure, we should pass it through. 
If the failure is LMDB-specific, and not related to any particular system 
call, then we should define an MDB_* code for it.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/