[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: (ITS#8105) [PATCH] slaptest doesn't convert perlModuleConfig lines
- To: openldap-its@OpenLDAP.org
- Subject: Re: (ITS#8105) [PATCH] slaptest doesn't convert perlModuleConfig lines
- From: hyc@symas.com
- Date: Mon, 27 Apr 2015 10:23:54 +0000
- Auto-submitted: auto-generated (OpenLDAP-ITS)
Jan Synacek wrote:
> Howard Chu <hyc@symas.com> writes:
>> Looks OK. One minor nit - we discourage using strlen() (or most of the
>> libc str* functions, really). We particularly discourage runtime
>> calculations on compile-time constants (including string constants) -
>> use the STRLENOF() macro instead.
>
> Done.
>
Thanks, in git master.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/