[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5



Jan Synacek wrote:
> Howard Chu <hyc@symas.com> writes:
>> jsynacek@redhat.com wrote:
>>> Full_Name: Jan Synacek
>>> Version: 2.4.40
>>> OS: GNU/Linux
>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-libdb-detection-with-gcc-5.patch
>>> Submission from: (NULL) (94.112.188.81)
>>>
>>>
>>> The old cpp version generated:
>>> __db_version 5
>>>
>>> Configure then correctly picked up the version, since it greps for
>>> "__db_version".
>>>
>>> The new output:
>>> __db_version
>>>               5
>>>
>>> Grepping no longer works and configure fails.
>>>
>>> Running cpp with -P (inhibit linemarkers generation) fixes this when using gcc
>>> 5.
>>> Behavior with older versions of gcc is not changed.
>>
>> Your patch is simple enough but frankly this sounds like a bug in gcc
>> 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle
>> of lines, or inserting line breaks arbitrarily.
>
> Yes, probably. But in the meantime, I needed the package to build, so I
> wrote this patch.

Please file a bug with the gcc project and followup here with a link to 
that bug, for future reference. Thanks.

Adding this patch to git master.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/