[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7293) [PATCH] Add missing function declarations and make some functions static

At Sat, 23 Jun 2012 05:42:15 -0700,
Howard Chu wrote:
> > Full_Name: SATOH Fumiyasu
> > Version: master, 2.4.31
> > OS:
> > URL: ftp://ftp.openldap.org/incoming/openldap-2.4.31-function-declarations.patch
> > Submission from: (NULL) (
> >
> >
> > This patch adds missing function declarations to *.h, and make some
> > functions and a global variable static.
> Thanks for the patch. In reviewing it, I see no reason to publish 
> ldap_pvt_sasl_getmechs or ldap_pvt_tls_check_hostname since neither is ever 
> referenced outside their defining source file. It looks like your addition of 

> ldap_create_session_tracking_control is also a mistake, you should simply have 
> fixed the declaration ldap_create_session_tracking (which is a nonexistent name).

Ah, right.

> Did you have a particular need to use these functions? Aside from the 

No. I'm not an LDAP API user, thus I don't know which functions
should be public or not. :-)

> ldap_create_session_tracking_control typo I don't think it's worth the trouble 
> to tweak the others.

-- Name: SATOH Fumiyasu (fumiyas @ osstech co jp)
-- Business Home: http://www.OSSTech.co.jp/
-- GitHub Home: https://GitHub.com/fumiyas/