[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6977) ldapwhoami minor verbose bugfix patch submission



hyc@symas.com wrote:
> checker@d6.com wrote:
>> Full_Name: Chris Hecker
>> Version: 2.4.25
>> OS: centos 5.6
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (98.248.126.162)
>>
>>
>> Hi, ldapwhoami erroneously prints the "Result: Success (0)" string even if -v is
>> not specified due to a minor bug in the code.  Here is a fix.  I am running
>> 2.3.43, but just checked the latest repository version and the bug is still
>> there (although at line 203 now), so I marked the version above as latest.
>>
>> Thanks,
>> Chris
>
> It seems to me the better fix would be to change ldap_parse_result() to not
> populate matcheddn or text when their values are zero-length. Kurt, any
> particular reason things should continue to work as they currently do?

OK, they work according to the C API draft. (sigh.) Client tools patched in 
master.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/