[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6943) segfault in rwmmap in 2.4.25

On 05/23/2011 10:15 PM, Tim.Mooney@ndsu.edu wrote:

> Thank you Pierangelo.  We've been running with that patch since last
> Friday without problems, so I'm comfortable with the fix.
> If you can do so without having to spend much time on it, could you give
> a brief overview of what you believe might be involved in implementing the
> longer fix?  I won't make any promises, but if you give me a hint at what
> would be involved, I might be able to contribute the code to skip mapping
> when not needed.  That seems like it would be very beneficial.

I don't think it's worth the effort, because mapping and rewriting are 
somehow tightly joined, so as soon as the overlay is loaded it is nearly 
always worth to scan all data to check whether intervention is needed. 
Further optimization would make the code even more hairy without 
significant improvements.