[Date Prev][Date Next]
Re: (ITS#6301) PATCH - used red-black tree for response messages
- To: openldap-its@OpenLDAP.org
- Subject: Re: (ITS#6301) PATCH - used red-black tree for response messages
- From: firstname.lastname@example.org
- Date: Wed, 23 Sep 2009 00:08:04 GMT
- Auto-submitted: auto-generated (OpenLDAP-ITS)
> Full_Name: Bryan Duncan
> Version: 2.4.16
> OS: Mac OS X 10.6
> URL: ftp://ftp.openldap.org/incoming/bryan-duncan-rbtree-090922.patch
> Submission from: (NULL) (126.96.36.199)
> Uploaded patch that replaces the linked-list of response messages with a
> red-black tree. This improves performance since random access to the response
> messages is needed.
Hmm, there is no such file at the above URL.
Also, while I don't doubt that a tree structure beats a linked list for
performance, could you please describe the analysis that led you to writing
this patch? What problem were you tracking, and what situation caused it?
Why did you use a red-black tree, rather than just using the AVL code that's
already in the source?
In the future it would be a good idea to raise these topics on the
openldap-devel mailing list before diving in, since this is core functionality
and performance-related. Performance patches don't get committed without test
results showing a clear before/after gain.
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/