(ITS#6171) Kill or fix K&R support

[h.b.furuseth@usit.uio.no]

Full_Name: Hallvard B Furuseth
Version: 2.0.0 and later
OS: 
URL: http://www.openldap.org/lists/openldap-devel/200706/msg00009.html
Submission from: (NULL) (129.240.6.233)
Submitted by: hallvard


openldap-devel thread "Kill K&R C support?" from jun 2007,
edited into a single quote/response stream:

Hallvard B Furuseth wrote:
>Kurt Zeilenga wrote:
>>Hallvard B Furuseth wrote:
>>> As far as I can tell, OpenLDAP has been unusable with K&R C since
>>> openldap-2.0:  lber.h in that release had prototypes unprotected
>>> by LDAP_P() in struct sockbuf_io.  They've been there ever since.
>>> So LDAP_P() can [edit: probably] go.
>>
>> I note that the intent was to allow use of -lldap/-llber in K&R C
>> programs, but to require ISO C to build OpenLDAP Software.
>
> Which I think made sense.  But now, apparently nobody has complained
> about the problem for 7 years.  Time to quit worrying about K&R?
> 
>> Seems the former is broken (lber.h issues).

Still broken today (jun 2009).

>>> Don't know which other not-strict-ISO support is still useful -
>>> I note lber.h has used <string.h> since openldap-2.2.4, for example.
>>> libldap/open.c has used <limits.h> since 2.0.0.
>>
>> The latter isn't a problem with regard to the above intent.
>>
>>> HEAD wraps that
>>> in HAVE_LIMITS_H, but it does not protect INT_MAX the same way.
>>
>> Likewise.