[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5751) undefined value in slapo-constraint with bad filter

h.b.furuseth@usit.uio.no wrote:
> Full_Name: Hallvard B Furuseth
> Version: HEAD, RE24
> OS:
> URL:
> Submission from: (NULL) (
> Submitted by: hallvard
> overlays/constraint.c:constraint_violation() uses and maybe returns an
> undefined value in 'rc' if the filter is bad (nop.ors_filter == NULL).
> I have no idea what rc should be in this case.
> Introduced in constraint.c 1.18 (OpenLDAP 2.4.12).

Probably should just set rc=LDAP_SUCCESS in this case. The constraint is 
invalid, so it cannot be violated.
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/