[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5564) Use largest contextCSN to determine staleness?

rein@OpenLDAP.org wrote:
>    This message is in MIME format.  The first part should be readable text,
>    while the remaining parts are likely unreadable without MIME-aware tools.
> --8323329-1817437300-1213728437=:15378
> Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
> On Mon, 16 Jun 2008, rein@OpenLDAP.org wrote:
> rein@OpenLDAP.org wrote:
>> A fix that seems to solve this is that syncprov_findbase(FIND_CSN)
>> should search for entries whose entryCSN value is less than the
>> largest contextCSN presented by the client.  All the test scripts
>> succeed if I try this, but I'm not convinced that this is the correct
>> fix.  Would it not be more correct to ignore the entire CSN set
>> presented by the consumer when it has been determined as stale.
> After looking a bit more on this I'm more convinced that the alternative
> fix is the correct.  A patch that implements this is attached, all tests
> succeed with it.  Howard, can you approve or comment on it?

This patch looks OK to me, go ahead and commit.

   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/