Re: (ITS#5564) Use largest contextCSN to determine staleness?

[rein@OpenLDAP.org]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1817437300-1213728437=:15378
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed


On Mon, 16 Jun 2008, rein@OpenLDAP.org wrote:

rein@OpenLDAP.org wrote:

> A fix that seems to solve this is that syncprov_findbase(FIND_CSN)
> should search for entries whose entryCSN value is less than the
> largest contextCSN presented by the client.  All the test scripts
> succeed if I try this, but I'm not convinced that this is the correct
> fix.  Would it not be more correct to ignore the entire CSN set
> presented by the consumer when it has been determined as stale.

After looking a bit more on this I'm more convinced that the alternative
fix is the correct.  A patch that implements this is attached, all tests
succeed with it.  Howard, can you approve or comment on it?

Rein
--8323329-1817437300-1213728437=:15378
Content-Type: TEXT/x-diff; name=ITS-5564.patch
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.DEB.1.00.0806172047070.15378@monster.tollevik.no>
Content-Description: 
Content-Disposition: attachment; filename=ITS-5564.patch

SW5kZXg6IHNlcnZlcnMvc2xhcGQvb3ZlcmxheXMvc3luY3Byb3YuYw0KPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9mL0NWU1JPT1QvZHJp
ZnQvT3BlbkxEQVAvc2VydmVycy9zbGFwZC9vdmVybGF5cy9zeW5jcHJvdi5j
LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMA0KZGlmZiAtdSAtdSAtcjEu
MzAgc3luY3Byb3YuYw0KLS0tIHNlcnZlcnMvc2xhcGQvb3ZlcmxheXMvc3lu
Y3Byb3YuYwkxMyBKdW4gMjAwOCAxMzo0OTozNiAtMDAwMAkxLjMwDQorKysg
c2VydmVycy9zbGFwZC9vdmVybGF5cy9zeW5jcHJvdi5jCTE3IEp1biAyMDA4
IDEzOjA3OjUxIC0wMDAwDQpAQCAtMjMyMyw2ICsyMzIzLDE1IEBADQogCQkJ
CXNlbmRfbGRhcF9lcnJvciggb3AsIHJzLCBMREFQX1NZTkNfUkVGUkVTSF9S
RVFVSVJFRCwgInN5bmMgY29va2llIGlzIHN0YWxlIiApOw0KIAkJCQlyZXR1
cm4gcnMtPnNyX2VycjsNCiAJCQl9DQorCQkJaWYgKCBzcnMtPnNyX3N0YXRl
LmN0eGNzbiApIHsNCisJCQkJYmVyX2J2YXJyYXlfZnJlZV94KCBzcnMtPnNy
X3N0YXRlLmN0eGNzbiwgb3AtPm9fdG1wbWVtY3R4ICk7DQorCQkJCXNycy0+
c3Jfc3RhdGUuY3R4Y3NuID0gTlVMTDsNCisJCQl9DQorCQkJaWYgKCBzcnMt
PnNyX3N0YXRlLnNpZHMgKSB7DQorCQkJCXNsYXBfc2xfZnJlZSggc3JzLT5z
cl9zdGF0ZS5zaWRzLCBvcC0+b190bXBtZW1jdHggKTsNCisJCQkJc3JzLT5z
cl9zdGF0ZS5zaWRzID0gTlVMTDsNCisJCQl9DQorCQkJc3JzLT5zcl9zdGF0
ZS5udW1jc25zID0gMDsNCiAJCX0gZWxzZSB7DQogCQkJZ290c3RhdGUgPSAx
Ow0KIAkJCS8qIElmIGNoYW5nZWQgYW5kIGRvaW5nIFByZXNlbnQgbG9va3Vw
LCBzZW5kIFByZXNlbnQgVVVJRHMgKi8NCg==

--8323329-1817437300-1213728437=:15378--