[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5536) Always use a configured serverID in the syncrepl cookie

On Thu, 29 May 2008, hyc@symas.com wrote:

> rein@OpenLDAP.org wrote:
>> On Wed, 28 May 2008, Howard Chu wrote:
>>> rein@OpenLDAP.org wrote:
>>>> Syncrepl includes the serverID in the syncCookie in multi-master mode only,
>>>> but
>>>> there are other configuration that would benefit from it as well.
>> The commited fix for this bug causes test033-glue-syncrepl to fail.  The
>> serverID is not set by the config, which makes syncprov_qresp() skip the
>> delete when it fins that the consumer presented a cookie with its own sid
>> value.
> OK then I guess you're right and we need the default to be -1.

I see you have commited an alternative version to syncrepl.c.  This 
version don't include the serverID in the cookie when syncrepl is used on 
the glue database itself, only when used on subordinate DBs.  And 
unfortunately, it is when used on the glue database it is needed (at least 
in my configuration).

So, I still think we have to always include it when it is configured. 
Unless there exist some easy way to know that a subordinate DB is not 
managed by syncrepl.  The only solution I know to that is to loop through 
all the subordinate DBs and compare the rootdn values.