[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5457) bdb_add() does not always release entries

hyc@symas.com writes:
>>          bdb_unlocked_cache_return_entry_r(&bdb->bi_cache, p );
>> (...)
> Releasing entries is somewhat irrelevant, since all locks are released when
> the transaction commits. Note that this function is a no-op in proto-bdb.h.
> All of those statements are just relics from the first entry cache design,
> before we switched to using BDB locks for everything.

OK.  Does that apply to bdb_cache_return_entry_r( bdb, oe, &lock );
	bdb_cache_add( bdb, ei, op->ora_e, &nrdn, rlocker, &lock );
	failed TXN_COMMIT( ltid, 0 );
too?  bdb_cache_return_entry_r() is not a no-op.