[Date Prev][Date Next] [Chronological] [Thread] [Top]

RE: (ITS#3460) Adding LDAP statistics script to contrib directory



<quote who="daveh@ci.com.au">
>> Do you mind if I do some clean up on it?
>>
>> Mainly Perl::Critic and Perl::Tidy. There's a few tests missing and
>> assumptions been made with opening files and system commands etc.
>
> You might also highlight the fact that it seems to require at least 5.8
> (due to the "qw()" lists).

Well, according to the method I always use to check that,
Perl::MinimumVersion, we get:

 perlver ldap-stats.pl


   --------------------------------------------
 | file          | explicit | syntax | external |
 | -------------------------------------------- |
 | ldap-stats.pl | ~        | v5.6.0 | n/a      |
 | -------------------------------------------- |
 | Minimum explicit version : ~                 |
 | Minimum syntax version   : v5.6.0            |
 | Minimum version of perl  : v5.6.0            |
   --------------------------------------------


>
> I also don't like hard-wiring "/usr/bin/perl", as the system Perls are
> rarely up to date.  My favourite technique is:
>
> #! /usr/bin/env perl -w
>
> which finds Perl from $PATH.
>
> Or just hard-wire "/usr/local/bin/perl" and let the sysadmin sort it
> out...

Sounds good. env method is best I suppose, but there are others as listed at:

http://perldoc.perl.org/perlrun.html#DESCRIPTION

Almost finished that cleanup. It's taken a bit longer than expected.

Thanks.

-- 
Kind Regards,

Gavin Henry.
Managing Director.

T +44 (0) 1224 279484
M +44 (0) 7930 323266
F +44 (0) 1224 824887
E ghenry@suretecsystems.com

Open Source. Open Solutions(tm).

http://www.suretecsystems.com/