[Date Prev][Date Next]
RE: (ITS#3460) Adding LDAP statistics script to contrib directory
> Do you mind if I do some clean up on it?
> Mainly Perl::Critic and Perl::Tidy. There's a few tests missing and
> assumptions been made with opening files and system commands etc.
You might also highlight the fact that it seems to require at least 5.8
(due to the "qw()" lists).
I also don't like hard-wiring "/usr/bin/perl", as the system Perls are
rarely up to date. My favourite technique is:
#! /usr/bin/env perl -w
which finds Perl from $PATH.
Or just hard-wire "/usr/local/bin/perl" and let the sysadmin sort it
Dave Horsfall DTM VK2KFU email@example.com Ph: +61 2 9552-5509 (d) -5500 (sw)
Corinthian Eng'ng P/L, Ste 54 Jones Bay Whf, 26-32 Pirrama Rd, Pyrmont 2009, AU