[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#4606) Big LDAP Search responses causes IO error in libldap on Windows XP



Alexey Melnikov wrote:

>> In your patch, directly including <errno.h> should not be needed, 
>> since <ac/errno.h> will include it already. If <ac/errno.h> isn't 
>> bringing in <errno.h> for you then it appears you have a configure 
>> problem.
>
> That is fine.
>
> This reminds me that there is another problem with configure. The 
> following code in <ac/errno.h> doesn't compile with Visual Studio 8:
>
> #elif DECL_SYS_ERRLIST
>    /* have sys_errlist but need declaration */
>    LDAP_LIBC_V(int)      sys_nerr;
>    LDAP_LIBC_V(char)    *sys_errlist[];
> #endif
>
> sys_errlist and sys_nerr are defined in <stdlib.h>, and not in <errno.h>

I've fixed this partucular problem by including the following in 
<ac/errno.h>

#if defined(_MSC_VER)
# include <stdlib.h>
#undef DECL_SYS_ERRLIST
#endif

But a change to configure script to look for sys_errlist/sys_nerr might 
be cleaner.