Re: variable used before set in servers/slapd/syncrepl.c (ITS#4331)

[Kurt@OpenLDAP.org]

Please report this separately from the syncrepl issue.

At 09:03 AM 1/12/2006, fenlason@redhat.com wrote:
>On Thu, Jan 12, 2006 at 12:24:12AM +0100, Pierangelo Masarati wrote:
>> On Wed, 2006-01-11 at 21:07 +0000, fenlason@redhat.com wrote:
>> 
>> > I'm looking through all the warning messages generated when I build
>> > 2.3.17.  Expect another bug report when I've gone through them all.
>> > Most of them are "warning: too many arguments for format" because of
>> > the Debug macro (I think),
>> 
>> Right, you may (safely?) ignore them; they will eventually disappear as
>> logging gets redesigned.
>> 
>> > but a few of them look like they might be
>> > real.
>> 
>> In my builds, apart from few mostly useless modules all warnings are
>> "too many args" or "type punned/strict aliasing" stuff (gcc 3.4.4 -Wall
>> -Wextra -pedantic).
>> 
>> If you find anything else, please report.  Thanks, p.
>
>All the real  used-before-set errors are in the bdb part of the build, so
>not your problem.  I did notice:
>
>../../../libraries/libldap/tls.c: In function 'tls_get_cert':
>../../../libraries/libldap/tls.c:879: warning: implicit declaration of function 'ssl3_send_alert'
>
>This looks like it's using an openssl internal function, which is
>probably a no-no.
>
>../../../libraries/libldap/test.c: In function 'get_modlist':
>../../../libraries/libldap/test.c:172: warning: 'tmp.mod_op' may be used uninitialized in this function
>
>This looks like it could be real, but it looks like test code.  The
>easy solution would be to bzero (erm memset) the structure before the
>loop.
>
>../../../libraries/libldap_r/thr_posix.c: In function 'ldap_pvt_thread_set_concurrency':
>../../../libraries/libldap_r/thr_posix.c:58: warning: implicit declaration of function 'pthread_setconcurrency'
>../../../libraries/libldap_r/thr_posix.c: In function 'ldap_pvt_thread_get_concurrency':
>../../../libraries/libldap_r/thr_posix.c:72: warning: implicit declaration of function 'pthread_getconcurrency'
>../../../libraries/libldap_r/thr_posix.c: In function 'ldap_pvt_thread_kill':
>../../../libraries/libldap_r/thr_posix.c:174: warning: implicit declaration of function 'pthread_kill'
>
>I think these are actually "bugs" in the pthread header files.  I
>can't find a declaration for pthread_kill() anywhere, although it has
>a man page.  The others don't have man pages, and the declarations are
>hidden behind an #ifdef.
>
>                        -- JF