Re: variable used before set in servers/slapd/syncrepl.c (ITS#4331)

[ando@sys-net.it]

On Thu, 2006-01-12 at 12:03 -0500, Jay Fenlason wrote:

> All the real  used-before-set errors are in the bdb part of the build, so
> not your problem.  I did notice:
> 
> ../../../libraries/libldap/tls.c: In function 'tls_get_cert':
> ../../../libraries/libldap/tls.c:879: warning: implicit declaration of function 'ssl3_send_alert'
> 
> This looks like it's using an openssl internal function, which is
> probably a no-no.

^^^ this has already been discussed in the past; I do not recall the
exact reason (and I'm too lazy to look it up in the archives) but yes,
it's calling an internal for something that has to be done that way.
Call it a "limitation" of ssl API...

> 
> ../../../libraries/libldap/test.c: In function 'get_modlist':
> ../../../libraries/libldap/test.c:172: warning: 'tmp.mod_op' may be used uninitialized in this function
> 
> This looks like it could be real, but it looks like test code.  The
> easy solution would be to bzero (erm memset) the structure before the
> loop.

right; but ll in all it's a harmless test.

> 
> ../../../libraries/libldap_r/thr_posix.c: In function 'ldap_pvt_thread_set_concurrency':
> ../../../libraries/libldap_r/thr_posix.c:58: warning: implicit declaration of function 'pthread_setconcurrency'
> ../../../libraries/libldap_r/thr_posix.c: In function 'ldap_pvt_thread_get_concurrency':
> ../../../libraries/libldap_r/thr_posix.c:72: warning: implicit declaration of function 'pthread_getconcurrency'
> ../../../libraries/libldap_r/thr_posix.c: In function 'ldap_pvt_thread_kill':
> ../../../libraries/libldap_r/thr_posix.c:174: warning: implicit declaration of function 'pthread_kill'
> 
> I think these are actually "bugs" in the pthread header files.  I
> can't find a declaration for pthread_kill() anywhere, although it has
> a man page.  The others don't have man pages, and the declarations are
> hidden behind an #ifdef.

Right.

Thanks, p.




Ing. Pierangelo Masarati
Responsabile Open Solution
OpenLDAP Core Team

SysNet s.n.c.
Via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
------------------------------------------
Office:   +39.02.23998309          
Mobile:   +39.333.4963172
Email:    pierangelo.masarati@sys-net.it
------------------------------------------