[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Patch: Wrong return types for ber_scanf and ber_flatten (ITS#1701)

Thanks.  I committed (to HEAD) fixes based upon your patch.


At 12:22 AM 2002-04-02, h.b.furuseth@usit.uio.no wrote:
>Full_Name: Hallvard B. Furuseth
>Version: 2.1.0alpha
>OS: Linux
>URL: http://folk.uio.no/hbf/OpenLDAP/ber-returntype.txt
>Submission from: (NULL) (
>Fix code which assigns the return value of ber_scanf to an int and then
>usually tests if that is LBER_ERROR, and which checks ber_flatten() ==
>LBER_ERROR instead of -1.
>The request.c patch patches rc=ber_printf instead because most uses
>of 'rc' is with ber_scanf, so it's simpler to change the type of 'rc'
>and then change the uses of 'rc' which are not with ber_scanf.