[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: idl_delete bug in back-ldbm?

> Look closily.  If the id was the only one in the list,
> ldbm_cache_delete() is called.  If the id isn't the only
> one on the list, the id is removed using SAFEMEMCPY()
> and stores the new list using idl_store().

Ah yes. I didn't realise that a copy operation can also delete.

> >Was this the right thing to do?
> It's probably better to change the caller to ignore the error
> (after logging it).  I'll commit such a change to -devel.

True. I haven't needed this patch since regenerating my gdbm database, but
I'm still happy that something good came from this.

Keep up the good work!