Created attachment 756 [details] Patch When cross-compiling, stripping fails because strip is used instead of $(STRIP). The attached patch (retrieved from https://git.buildroot.net/buildroot/tree/package/openldap/0001-fix_cross_strip.patch) fix this issue. I've also opened a Merge Request: https://git.openldap.org/openldap/openldap/-/merge_requests/101
Here is a quote from Yann's answer (from the Merge Request): This patch originates from the Buildroot project, and it is our policy that we want to push our patches upstream, which Fabrice took on him to do with that one. This patch has a proper assignment trail, with the usual "signed-off-by" tags (aka the DCO) like are used in the Linux kernel: - Dave, initial author who submitted the patch to the Buildroot project - I, Yann, who modified the patch - Fabrice, who eventually took it from the Buildroot project and submitted here. As for the licensing, we have a clear position in the Buildroot project, that the patches submitted to Buildroot are under the upstream licenses. All of the above combined makes it fully legit for Fabrice to submit here a patch that he did not author. The only nit here, maybe, is that Fabrice should probably have had the git-author field be Dave, not himself, though. This patch also only touches the build files. Of course the license for those is also important; still, the changes are trivial enough: there are only 6 new non-empty lines, and the other changes modify existing lines. As such, I understand they do fall below the "significant blocks of new code (10 lines or greater)" threshold defined in the contribution guidelines and thus do not require any further licensing notice.
Commits: • 8df03b43 by Fabrice Fontaine at 2020-08-25T19:54:59+00:00 ITS#9327 - Fix stripping when cross-compiling Probably-Signed-off-by: Dave Bender <bender@benegon.com> [yann.morin.1998@free.fr: patch was made by Dave, but he forgot his SoB line, so I added it] Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> [Retrieved from: https://git.buildroot.net/buildroot/tree/package/openldap/0001-fix_cross_strip.patch] Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
*** Issue 8416 has been marked as a duplicate of this issue. ***
Hm, this change now means that various bits are *always* stripped, overriding STRIP="", so this causes a new regression
Guess that will be user education. However, lloadd also needs fixing. https://git.openldap.org/openldap/openldap/-/merge_requests/240
Commits: • 5b2988ca by Quanah Gibson-Mount at 2021-02-17T19:55:25+00:00 ITS#9327 - Use STRIP_OPTS for lloadd