Issue 9237 - Remove back-perl from default build process
Summary: Remove back-perl from default build process
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: backends (show other issues)
Version: 2.5.4
Hardware: All All
: --- normal
Target Milestone: 2.5.0
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-22 17:05 UTC by Quanah Gibson-Mount
Modified: 2020-10-14 21:23 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Quanah Gibson-Mount 2020-04-22 17:05:29 UTC 
For 2.5, we will be removing back perl.

In master, remove the ability to build back perl, but keep the source

for the 2.5 branch, remove the source as well.
Comment 1 Howard Chu 2020-04-22 17:52:27 UTC 
(In reply to Quanah Gibson-Mount from comment #0)
> For 2.5, we will be removing back perl.
> 
> In master, remove the ability to build back perl, but keep the source

To be clear, we are only disabling the build. Anyone should still be
able to explicitly enable the build.
Comment 2 Quanah Gibson-Mount 2020-04-22 21:09:09 UTC 
To clarify:

In master, remove back-perl from the default backends, but still allow it to be explicitly enabled.

In RE25, remove back-perl entirely.
Comment 3 Ryan Tandy 2020-04-23 16:47:29 UTC 
Sounds like back-perl may not be as thread-unsafe as previously thought. Should probably investigate more before going ahead with this. Not sure how best to confirm whether safe or not...
Comment 4 Howard Chu 2020-04-23 17:50:45 UTC 
(In reply to Ryan Tandy from comment #3)
> Sounds like back-perl may not be as thread-unsafe as previously thought.
> Should probably investigate more before going ahead with this. Not sure how
> best to confirm whether safe or not...

That all depends on how libperl was built. Since that's highly site-dependent, I think it's fair to leave the backend disabled by default (removed from --enable-backends).
Comment 5 Quanah Gibson-Mount 2020-04-23 18:31:18 UTC 
(In reply to Howard Chu from comment #4)
> (In reply to Ryan Tandy from comment #3)
> > Sounds like back-perl may not be as thread-unsafe as previously thought.
> > Should probably investigate more before going ahead with this. Not sure how
> > best to confirm whether safe or not...
> 
> That all depends on how libperl was built. Since that's highly
> site-dependent, I think it's fair to leave the backend disabled by default
> (removed from --enable-backends).

We've also had various reports that it's not even functional currently (such as bug#8591)...
Comment 6 Ryan Tandy 2020-04-24 02:29:50 UTC 
Bug 8591 is a valid bug, and there may be others, but it doesn't look completely unusable. We could perhaps keep the code in 2.5 but remove it from --enable-backends, same as master?
Comment 7 Quanah Gibson-Mount 2020-04-28 20:19:02 UTC 
(In reply to Ryan Tandy from comment #6)
> Bug 8591 is a valid bug, and there may be others, but it doesn't look
> completely unusable. We could perhaps keep the code in 2.5 but remove it
> from --enable-backends, same as master?

I'm fine with that.
Comment 9 Quanah Gibson-Mount 2020-05-28 15:09:29 UTC 
Commits: 
  • aa206be5 
by Quanah Gibson-Mount at 2020-05-26T20:50:22+00:00 
Issue#9234, Issue#9237 - drop back-sql, back-perl from --enable-backends