Issue 9227 - Fix syncrepl exattrs to not delete local attrs
Summary: Fix syncrepl exattrs to not delete local attrs
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.50
Hardware: All All
: --- blocker
Target Milestone: 2.4.51
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-17 15:27 UTC by Quanah Gibson-Mount
Modified: 2020-08-19 16:22 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Quanah Gibson-Mount 2020-04-17 15:27:55 UTC
An issue with syncrepl using exattrs is that the local replica may delete attrs that are being managed by locally deployed overlays such as memberOf (See bug#7400 for example).  This behavior needs to be fixed so that the locally managed attributes are not deleted when included in an exattrs statement.
Comment 1 Howard Chu 2020-05-08 14:22:38 UTC
(In reply to Quanah Gibson-Mount from comment #0)
> An issue with syncrepl using exattrs is that the local replica may delete
> attrs that are being managed by locally deployed overlays such as memberOf
> (See bug#7400 for example).  This behavior needs to be fixed so that the
> locally managed attributes are not deleted when included in an exattrs
> statement.

Actually, it looks to me like exattrs has been handled correctly for quite a few years now. We need to see a test case showing that it's actually broken.
Comment 2 Howard Chu 2020-05-08 15:24:53 UTC
Never mind, I see where a check was missing. Fixed now in master.
Comment 3 Quanah Gibson-Mount 2020-05-11 15:03:07 UTC
commit 5462fc26b500c8cf0b0d7377c556b1a3b8c6cf05
Author: Howard Chu <hyc@openldap.org>
Date:   Fri May 8 16:22:44 2020 +0100

    ITS#9227 syncrepl: don't delete non-replicated attrs

commit f5ff1dad7e7a956636e99c838e06acb45f09d299
Author: Howard Chu <hyc@openldap.org>
Date:   Fri May 8 18:50:58 2020 +0100

    ITS#9227 fix attr / opattr detection in prev commit
Comment 4 Quanah Gibson-Mount 2020-05-11 21:47:37 UTC
RE24:

  • cc79c9e8 
by Howard Chu at 2020-05-11T21:45:44+00:00 
ITS#9227 syncrepl: don't delete non-replicated attrs


  • 1532254d 
by Howard Chu at 2020-05-11T21:45:51+00:00 
ITS#9227 fix attr / opattr detection in prev commit