Full_Name: Jean-Christophe Dubois Version: 2.4.40 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.235.240.156) In function mdb_txn_begin() at line 2672 there is a check for the parent pointer. The same check is done few lines earlier (line 2665) and if the condition was met the program would have skip the all section to ok: So code line 2673 can never be reached. It could be removed. Patch available at URL below: https://github.com/jcdubois/lmdb/commit/a3770a5fef56417ceea677efbbde768755188af4 JC
jcd@tribudubois.net wrote: > Full_Name: Jean-Christophe Dubois > Version: 2.4.40 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (78.235.240.156) > > > In function mdb_txn_begin() at line 2672 there is a check for the parent > pointer. > > The same check is done few lines earlier (line 2665) and if the condition was > met the program would have skip the all section to ok: > > So code line 2673 can never be reached. It could be removed. Thanks. This was leftover from 4d02c741b120786df1b87ee9ed49c1d3f9bc7522. Fixed in mdb.master. > > Patch available at URL below: > > https://github.com/jcdubois/lmdb/commit/a3770a5fef56417ceea677efbbde768755188af4 > > JC > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
fixed in mdb.master
changed notes changed state Open to Test moved from Incoming to Software Bugs
changed state Test to Release
changed state Release to Closed