Issue 6761 - contrib usn overlay broken
Summary: contrib usn overlay broken
Status: UNCONFIRMED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: contrib (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-31 15:53 UTC by Hallvard Furuseth
Modified: 2021-07-07 15:59 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Hallvard Furuseth 2010-12-31 15:53:37 UTC
Full_Name: Hallvard B Furuseth
Version: HEAD
OS: 
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (129.240.6.233)
Submitted by: hallvard


The usn overlay:

- Has init function usn_init instead of usn_initialize.

- Won't start, the attributes need a SYNTAX slapd knows and
  USAGE directoryOperation after NO-USER-MODIFICATION.

- Modifies sr->sr_entry in usn_operational() instead of putting
  the attribute in rs->sr_operational_attrs.  See
  back-bdb/operational.c for an example.

  Note, backend.c says
	/* NOTE: backend_operational() is also called
	 * when returning results, so it's supposed
	 * to do no harm to entries */
  which presumably means something more than just having to dup
  the entry and set MUSTBEFREED, since otherwise that comment
  applies to much more than just backend_operational().

  In fact, usn_operational() has some misindented code
			if ( !a ) {
				for ( ap = &rs->sr_operational_attrs; *ap;
					ap=&(*ap)->a_next );

					a = attr_alloc( ad_usnChanged );
					*ap = a;
				}
  which looks like it does something closer to that.

- When I tried to slapadd some entires (using Octet String
  syntax) only the first entry got an USN.

Oh well, this wasn't what I was supposed to be doing today.  I'm
just patching the overlay blindly for some other things (ITS#6758).
Comment 1 Howard Chu 2011-06-09 09:12:53 UTC
moved from Incoming to Development