Issue 6672 - OpenLDAP LDAP_R_COMPILE cleanup (LDAP_MUTEX_LOCK/LDAP_MUTEX_UNLOCK)
Summary: OpenLDAP LDAP_R_COMPILE cleanup (LDAP_MUTEX_LOCK/LDAP_MUTEX_UNLOCK)
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: build (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-12 19:15 UTC by doug.leavitt@oracle.com
Modified: 2020-03-23 19:12 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description doug.leavitt@oracle.com 2010-10-12 19:15:11 UTC
Full_Name: Douglas Leavitt
Version: HEAD
OS: OpenSolaris
URL: http://cr.opensolaris.org/~djl/openldap-patch2/
Submission from: (NULL) (192.18.43.225)


This patch is part 2 of 3 of the original ITS #6625 effort.
(aka openldap draft-zeilenga-ldap-c-api-concurrency)

As discussed on openldap-devel@openldap.org, #6625 is to be split into 3
distinct patches.

This patch cleans up much of the LDAP_R_COMPILE ifdefs in libldap.
The patch converts almost all

#ifdef LDAP_R_COMPILE
ldap_pvt_thread_mutex_[un]lock(...)
#endif

sequences to simpler
LDAP_MUTEX_[UN]LOCK macros.

No behavioral changes are introduced by this patch.  It is strictly a
code cleanup patch.

Regression testing (post conversion) performed using both
32-bit and 64-bit x86 compiles on an OpenSolaris system.

IPR Notice

This patch file is derived from OpenLDAP Software. All of the modifications to
OpenLDAP Software represented in the following patch(es) were developed
by Oracle Corporation.  Oracle Corporation has not assigned rights and/or
interest in this work to any party. I, Douglas Leavitt am authorized by Oracle
Corporation, my employer, to release this work under the following terms.
Comment 1 Howard Chu 2010-10-12 23:46:27 UTC
changed notes
changed state Open to Test
moved from Incoming to Build
Comment 2 Howard Chu 2010-10-13 06:45:50 UTC
doug.leavitt@oracle.com wrote:
> Full_Name: Douglas Leavitt
> Version: HEAD
> OS: OpenSolaris
> URL: http://cr.opensolaris.org/~djl/openldap-patch2/
> Submission from: (NULL) (192.18.43.225)
>
>
> This patch is part 2 of 3 of the original ITS #6625 effort.
> (aka openldap draft-zeilenga-ldap-c-api-concurrency)
>
> As discussed on openldap-devel@openldap.org, #6625 is to be split into 3
> distinct patches.
>
> This patch cleans up much of the LDAP_R_COMPILE ifdefs in libldap.
> The patch converts almost all
>
> #ifdef LDAP_R_COMPILE
> ldap_pvt_thread_mutex_[un]lock(...)
> #endif
>
> sequences to simpler
> LDAP_MUTEX_[UN]LOCK macros.
>
> No behavioral changes are introduced by this patch.  It is strictly a
> code cleanup patch.

Thanks, committed.
>
> Regression testing (post conversion) performed using both
> 32-bit and 64-bit x86 compiles on an OpenSolaris system.
>
> IPR Notice
>
> This patch file is derived from OpenLDAP Software. All of the modifications to
> OpenLDAP Software represented in the following patch(es) were developed
> by Oracle Corporation.  Oracle Corporation has not assigned rights and/or
> interest in this work to any party. I, Douglas Leavitt am authorized by Oracle
> Corporation, my employer, to release this work under the following terms.
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 3 Quanah Gibson-Mount 2011-01-03 14:02:52 UTC
changed notes
changed state Test to Release
Comment 4 Quanah Gibson-Mount 2011-02-14 12:26:06 UTC
changed notes
changed state Release to Closed
Comment 5 OpenLDAP project 2014-08-01 21:04:05 UTC
committed in HEAD
committed to RE24