Full_Name: Rafal Szczesniak Version: HEAD OS: GNU/Linux URL: http://www.samba.org/~mimir/gssapi-head.diff Submission from: (NULL) (12.104.75.4) OpenLDAP client libraries do not implement convenient mechanisms for interfacing to MS Active Directory with minimum necessary configuration. Also, SASL implementation is tightly connected with Cyrus SASL libs. Submitted patch modifies the library to provide more generic SASL layer used both by Cyrus SASL and contributed GSSAPI mechanism. The GSSAPI itself is limited to Kerberos 5, at the moment, but the goal is to provide complete SASL layer for easy connecting to MS servers.
changed notes changed state Open to Suspended moved from Incoming to Contrib
changed notes
On Feb 11, 2008, at 1:09 AM, mimir@samba.org wrote: > Full_Name: Rafal Szczesniak > Version: HEAD > OS: GNU/Linux > URL: http://www.samba.org/~mimir/gssapi-head.diff The submitted patch file does not contain (at the top of the file, not as part of the diffs) the required notices. Please review http://www.openldap.org/devel/contributing.html and insert appropriate notices. Also, please don't include in the diffs derived files (e.g., configure). -- Kurt
Kurt, On Mon, Feb 11, 2008 at 09:06:19AM -0800, Kurt Zeilenga wrote: > On Feb 11, 2008, at 1:09 AM, mimir@samba.org wrote: > >> Full_Name: Rafal Szczesniak >> Version: HEAD >> OS: GNU/Linux >> URL: http://www.samba.org/~mimir/gssapi-head.diff > > The submitted patch file does not contain (at the top of the file, not > as part of the diffs) the required notices. I'm sorry about that. I was submitting it late yesterday and must have missed that. I'll update the diff and let you know soon. > Please review > http://www.openldap.org/devel/contributing.html and insert appropriate > notices. Also, please don't include in the diffs derived files (e.g., > configure). Of course. My mistake. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewisesoftware.com
Kurt, On Mon, Feb 11, 2008 at 09:06:19AM -0800, Kurt Zeilenga wrote: >> Full_Name: Rafal Szczesniak >> Version: HEAD >> OS: GNU/Linux >> URL: http://www.samba.org/~mimir/gssapi-head.diff > > The submitted patch file does not contain (at the top of the file, not > as part of the diffs) the required notices. Please review > http://www.openldap.org/devel/contributing.html and insert appropriate > notices. Also, please don't include in the diffs derived files (e.g., > configure). I've updated the patch file with necessary changes. Please take a look if it's fine now. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewisesoftware.com
You've only included one of the two required statements. You need also need to include either a copyright + license statement, or a public domain release statement. -- Kurt On Feb 14, 2008, at 9:12 AM, mimir@samba.org wrote: > > --OgqxwSJOaUobr8KG > Content-Type: text/plain; charset=iso-8859-2 > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > Kurt, > > On Mon, Feb 11, 2008 at 09:06:19AM -0800, Kurt Zeilenga wrote: >>> Full_Name: Rafal Szczesniak >>> Version: HEAD >>> OS: GNU/Linux >>> URL: http://www.samba.org/~mimir/gssapi-head.diff >> >> The submitted patch file does not contain (at the top of the file, >> not = > =20 >> as part of the diffs) the required notices. Please review=20 >> http://www.openldap.org/devel/contributing.html and insert >> appropriate=20 >> notices. Also, please don't include in the diffs derived files >> (e.g.,=20 >> configure). > > I've updated the patch file with necessary changes. Please take a look > if it's fine now. > > > cheers, > --=20 > Rafal Szczesniak > Samba Team member http://www.samba.org > Likewise Software http://www.likewisesoftware.com > > > --OgqxwSJOaUobr8KG > Content-Type: application/pgp-signature; name="signature.asc" > Content-Description: Digital signature > Content-Disposition: inline > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFHtJLCHvdfyv3qiKkRArL0AJ9ZazJE3LUduZb3A8rz21KheW/EYQCfQt8z > F7AnIDF5EkJ7ssDwHStryEo= > =tIVf > -----END PGP SIGNATURE----- > > --OgqxwSJOaUobr8KG-- > >
I note that the patch appears to be incomplete. No gssapi.c included. -- Kurt On Feb 14, 2008, at 8:26 PM, kurt@openldap.org wrote: > You've only included one of the two required statements. You need > also need to include either a copyright + license statement, or a > public domain release statement. -- Kurt > > On Feb 14, 2008, at 9:12 AM, mimir@samba.org wrote: > >> >> --OgqxwSJOaUobr8KG >> Content-Type: text/plain; charset=iso-8859-2 >> Content-Disposition: inline >> Content-Transfer-Encoding: quoted-printable >> >> Kurt, >> >> On Mon, Feb 11, 2008 at 09:06:19AM -0800, Kurt Zeilenga wrote: >>>> Full_Name: Rafal Szczesniak >>>> Version: HEAD >>>> OS: GNU/Linux >>>> URL: http://www.samba.org/~mimir/gssapi-head.diff >>> >>> The submitted patch file does not contain (at the top of the file, >>> not = >> =20 >>> as part of the diffs) the required notices. Please review=20 >>> http://www.openldap.org/devel/contributing.html and insert >>> appropriate=20 >>> notices. Also, please don't include in the diffs derived files >>> (e.g.,=20 >>> configure). >> >> I've updated the patch file with necessary changes. Please take a >> look >> if it's fine now. >> >> >> cheers, >> --=20 >> Rafal Szczesniak >> Samba Team member http://www.samba.org >> Likewise Software http://www.likewisesoftware.com >> >> >> --OgqxwSJOaUobr8KG >> Content-Type: application/pgp-signature; name="signature.asc" >> Content-Description: Digital signature >> Content-Disposition: inline >> >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v1.4.6 (GNU/Linux) >> >> iD8DBQFHtJLCHvdfyv3qiKkRArL0AJ9ZazJE3LUduZb3A8rz21KheW/EYQCfQt8z >> F7AnIDF5EkJ7ssDwHStryEo= >> =tIVf >> -----END PGP SIGNATURE----- >> >> --OgqxwSJOaUobr8KG-- >> >> > >
On Fri, Feb 15, 2008 at 09:28:56AM -1000, Kurt Zeilenga wrote: > I note that the patch appears to be incomplete. No gssapi.c included. Sorry about that. Wrong working dir when generating the patch. I've uploaded more complete file at http://samba.org/~mimir/head-gssapi.diff I've also added license notice. Let me know if there's anything else missing. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewisesoftware.com
On Mar 3, 2008, at 1:37 PM, mimir@samba.org wrote: > > --zhXaljGHf11kAtnf > Content-Type: text/plain; charset=iso-8859-2 > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Fri, Feb 15, 2008 at 09:28:56AM -1000, Kurt Zeilenga wrote: >> I note that the patch appears to be incomplete. No gssapi.c >> included. > > Sorry about that. Wrong working dir when generating the patch. I've > uploaded more complete file at http://samba.org/~mimir/head- > gssapi.diff > I've also added license notice. Let me know if there's anything else > missing. In your rights statement, you claim this patch is only derived from OpenLDAP Software. Is this correct? Are there are works from which your work is derived? That is, did you copy any material from any other work (e.g., Samba)? Please document any in the rights statement and, when complete, update the ITS (by email reply-all) indicating so. The rights statement needs to be amended to include a statement that the modifications are not subject to Stefan's employer. And then Stefan needs to send a copy of both statements from his email address to openldap-its@openldap.org with a subject of "ITS#5369 IPR statements" confirming they are correct. I've cc'ed Stefan on this note. I note my review is limited to IPR issues. There may well be technical issues to address separately from this. These will be handled separately (normally post IPR review). Regards, Kurt > > > > cheers, > --=20 > Rafal Szczesniak > Samba Team member http://www.samba.org > Likewise Software http://www.likewisesoftware.com > > > --zhXaljGHf11kAtnf > Content-Type: application/pgp-signature; name="signature.asc" > Content-Description: Digital signature > Content-Disposition: inline > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFHzG+9Hvdfyv3qiKkRAmFUAJ9mbHvUFgkz2f/urbdGwbjhSQ6mbQCeMxYZ > XF5OP4ZaFhwZ5T6rO1FJ4FM= > =Ii59 > -----END PGP SIGNATURE----- > > --zhXaljGHf11kAtnf-- > >
On Mon, Mar 03, 2008 at 02:50:49PM -0800, Kurt Zeilenga wrote: > On Mar 3, 2008, at 1:37 PM, mimir@samba.org wrote: > In your rights statement, you claim this patch is only derived from > OpenLDAP Software. Is this correct? Are there are works from which > your work is derived? That is, did you copy any material from any other > work (e.g., Samba)? Please document any in the rights statement and, > when complete, update the ITS (by email reply-all) indicating so. No, it is purely OpenLDAP work using GSS-API libraries. > The rights statement needs to be amended to include a statement that the > modifications are not subject to Stefan's employer. And then Stefan > needs to send a copy of both statements from his email address to > openldap-its@openldap.org with a subject of "ITS#5369 IPR statements" > confirming they are correct. I've cc'ed Stefan on this note. Thanks. The modifications are not subject to his employer, but thanks for cc-ing him. Sorry Metze, I should have not forgotten about this. > I note my review is limited to IPR issues. There may well be technical > issues to address separately from this. These will be handled separately > (normally post IPR review). Sure, I understand. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewisesoftware.com
Kurt, On Mon, Mar 03, 2008 at 02:50:49PM -0800, Kurt Zeilenga wrote: > In your rights statement, you claim this patch is only derived from > OpenLDAP Software. Is this correct? Are there are works from which > your work is derived? That is, did you copy any material from any other > work (e.g., Samba)? Please document any in the rights statement and, > when complete, update the ITS (by email reply-all) indicating so. > > The rights statement needs to be amended to include a statement that the > modifications are not subject to Stefan's employer. And then Stefan > needs to send a copy of both statements from his email address to > openldap-its@openldap.org with a subject of "ITS#5369 IPR statements" > confirming they are correct. I've cc'ed Stefan on this note. Have you received Stefan's copyright statement ? cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewisesoftware.com
changed notes changed state Suspended to Open
kurt@OpenLDAP.org wrote: > I note that the patch appears to be incomplete. No gssapi.c included. Sorry for the tardy review. The patch is also corrupted (both patches actually) and doesn't compile. Note this section of the patch to cyrus.c: +static ber_int_t +sb_sasl_cyrus_encode( + struct sb_sasl_generic_data *p, + unsigned char *buf, + ber_len_t len, + Sockbuf_Buf *dst) +{ + sasl_conn_t *sasl_context = (sasl_conn_t *)p->ops_private; + ber_int_t ret; + unsigned tmpsize = dst->buf_size; + + ret = sasl_encode( sasl_context, buf, len, + (SASL_CONST char **)&dst->buf_base, + &tmpsize ); - assert( sbiod != NULL ); + dst->buf_size = tmpsize; + dst->buf_end = dst->buf_ The last line appears to be truncated in both versions of the diff. > > -- Kurt > > On Feb 14, 2008, at 8:26 PM, kurt@openldap.org wrote: > >> You've only included one of the two required statements. You need >> also need to include either a copyright + license statement, or a >> public domain release statement. -- Kurt >> >> On Feb 14, 2008, at 9:12 AM, mimir@samba.org wrote: >> >>> --OgqxwSJOaUobr8KG >>> Content-Type: text/plain; charset=iso-8859-2 >>> Content-Disposition: inline >>> Content-Transfer-Encoding: quoted-printable >>> >>> Kurt, >>> >>> On Mon, Feb 11, 2008 at 09:06:19AM -0800, Kurt Zeilenga wrote: >>>>> Full_Name: Rafal Szczesniak >>>>> Version: HEAD >>>>> OS: GNU/Linux >>>>> URL: http://www.samba.org/~mimir/gssapi-head.diff >>>> The submitted patch file does not contain (at the top of the file, >>>> not = >>> =20 >>>> as part of the diffs) the required notices. Please review=20 >>>> http://www.openldap.org/devel/contributing.html and insert >>>> appropriate=20 >>>> notices. Also, please don't include in the diffs derived files >>>> (e.g.,=20 >>>> configure). >>> I've updated the patch file with necessary changes. Please take a >>> look >>> if it's fine now. >>> >>> >>> cheers, >>> --=20 >>> Rafal Szczesniak >>> Samba Team member http://www.samba.org >>> Likewise Software http://www.likewisesoftware.com >>> -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
changed notes changed state Open to Test
changed notes changed state Test to Release
changed notes changed state Release to Closed
IPR Okay Committed to HEAD with minor corrections Committed to RE24 with minor corrections