Full_Name: Buchan Milne Version: 2.4.25 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (196.25.124.16) While the code in contrib is not supported, some overlays provide make files, some don't, and there were variations in a lot of the make files (e.g. use of DESTDIR or not). In order to add make files for overlays that don't have them, improve the consistency of the make files between overlays that had them, and to provide some basic sanity testing in a 'test' target, I have created the patch at: http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/current/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=648744&view=markup The patch is against 2.4.25, but should apply to master (except that there two additional overlays are present in master). Where feasible I have retained the majority of an existing make file, in other cases, where modifications would exceed the original content, I have replaced existing make files wholesale. The attached patch file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not assigned rights and/or interest in this work to any party.
--On Tuesday, March 29, 2011 3:25 PM +0000 bgmilne@staff.telkomsa.net wrote: > Full_Name: Buchan Milne > Version: 2.4.25 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (196.25.124.16) > > > While the code in contrib is not supported, some overlays provide make > files, some don't, and there were variations in a lot of the make files > (e.g. use of DESTDIR or not). > > In order to add make files for overlays that don't have them, improve the > consistency of the make files between overlays that had them, and to > provide some basic sanity testing in a 'test' target, I have created the > patch at: > http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/curre > nt/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=64 > 8744&view=markup > > The patch is against 2.4.25, but should apply to master (except that > there two additional overlays are present in master). Where feasible I > have retained the majority of an existing make file, in other cases, > where modifications would exceed the original content, I have replaced > existing make files wholesale. > > The attached patch file is derived from OpenLDAP Software. All of the > modifications to OpenLDAP Software represented in the following patch(es) > were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not > assigned rights and/or interest in this work to any party. Hi Buchan, Can you make the patch available via git-format-patch? Thanks, Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration
On Tuesday, 29 March 2011 21:20:53 quanah@zimbra.com wrote: > --On Tuesday, March 29, 2011 3:25 PM +0000 bgmilne@staff.telkomsa.net wrote: > > Full_Name: Buchan Milne > > Version: 2.4.25 > > OS: Linux > > URL: ftp://ftp.openldap.org/incoming/ > > Submission from: (NULL) (196.25.124.16) > > > > > > While the code in contrib is not supported, some overlays provide make > > files, some don't, and there were variations in a lot of the make files > > (e.g. use of DESTDIR or not). > > > > In order to add make files for overlays that don't have them, improve the > > consistency of the make files between overlays that had them, and to > > provide some basic sanity testing in a 'test' target, I have created the > > patch at: > > http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/curre > > nt/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=64 > > 8744&view=markup > > > > The patch is against 2.4.25, but should apply to master (except that > > there two additional overlays are present in master). Where feasible I > > have retained the majority of an existing make file, in other cases, > > where modifications would exceed the original content, I have replaced > > existing make files wholesale. > > > > The attached patch file is derived from OpenLDAP Software. All of the > > modifications to OpenLDAP Software represented in the following patch(es) > > were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not > > assigned rights and/or interest in this work to any party. > > Hi Buchan, > > Can you make the patch available via git-format-patch? Please find it attached. Regards, Buchan
On Tuesday, 29 March 2011 17:25:10 you wrote: > Full_Name: Buchan Milne > Version: 2.4.25 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (196.25.124.16) > > > While the code in contrib is not supported, some overlays provide make > files, some don't, and there were variations in a lot of the make files > (e.g. use of DESTDIR or not). > > In order to add make files for overlays that don't have them, improve the > consistency of the make files between overlays that had them, and to > provide some basic sanity testing in a 'test' target, I have created the > patch at: > http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/curren > t/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=64874 > 4&view=markup > > The patch is against 2.4.25, but should apply to master (except that there > two additional overlays are present in master). Where feasible I have > retained the majority of an existing make file, in other cases, where > modifications would exceed the original content, I have replaced existing > make files wholesale. > > The attached patch file is derived from OpenLDAP Software. All of the > modifications to OpenLDAP Software represented in the following patch(es) > were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not > assigned rights and/or interest in this work to any party. Attached is an updated patch against current master (since ftp.openldap.org/incoming is out of disk space). Please let me know how we can get this patch merged. Regards, Buchan
changed notes moved from Incoming to Build
On Thu, 16 Feb 2012 11:38:13 GMT, bgmilne@staff.telkomsa.net wrote: > Please let me know how we can get this patch merged. OpenLDAP needs more active developers... Anyway: It should remove GNU Make dependencies, not introduce them: Only use '$<' in inference rules, not explicit target rules (like ITS#7160). Drop '%.x: %.y' rules. I've scribbled a draft for that at repo <http://folk.uio.no/hbf/OpenLDAP/openldap.git>, branch its6883. (Not tested, and I need to install a non-Gnu Make to test with too.) I'll work at it later, but don't quite know when. Unless you beat me to it. Also I suppose '+=' should go away. Which I would mean move what is added to a new variable so the user can easily say things like make CPPFLAGS='-Dwhatever $(DEFS)'. Or maybe use LT_CPPFLAGS= ..whatever $(CPPFLAGS) ... like e.g. slapd/overlays/Makefile ends up doing. THat one has an awful number of Make variables and is fairly unreadable to me, probably to satisfy autoconf & co. But a few more vars seems useful. -- Hallvard
changed notes
changed notes changed state Open to Closed
needs cleanup, e.g. drop GNU Make dependencies Fixed via ITS#7308