Re: commit: ldap/servers/slapd syncrepl.c

[Pierangelo Masarati <ando@sys-net.it>]

Howard Chu wrote:
> quanah@OpenLDAP.org wrote:
>> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
>>
>> Modified Files:
>>       Tag: OPENLDAP_REL_ENG_2_4
>>     syncrepl.c  1.254.2.9 -> 1.254.2.10
>>
>> Log Message:
>> make sure n,o are non-zero, so j is initialized (coverity)
> 
> Just a note for future consideration - the only way an attribute could
> have zero values here is if someone was doing an attrsonly search.
> Currently the syncrepl config allows you to perform such a search. It
> doesn't make much sense to me to do this though, perhaps we should
> eliminate that option.

Agree.  I think we decided long ago that a_vals, a_nvals always != NULL;
occasionally, a_nvals == a_vals.  There are now quite a few asserts
about this in the code.

p.



Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
---------------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Email:   pierangelo.masarati@sys-net.it
---------------------------------------