[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/servers/slapd/slapi slapi_overlay.c

hallvard@OpenLDAP.org writes:
> Modified Files:
> 	slapi_overlay.c  1.28 -> 1.29
> pb in slapi_op_func was freed uninitialized if preop_type==0 && !internal_op

Don't know if I fixed that in the right place.  I NULLed out pb before
doing goto cleanup:

        if ( !internal_op ) {
            cb.sc_private = NULL;

but maybe cb.sc_private should only be reset if pb != NULL instead of
only if !internal_op?

For sale: Parachute. Never opened, used once, slightly stained.