Re: (ITS#8841) Fix for an assertion error in back-meta

[nivanova@symas.com]

A new patch with added comments has been added at
ftp://ftp.openldap.org/incoming/nadezhda-ivanova-190214.patch

More details about this issue:
The customer reported that when they simulated a "network unreachable" error, SLAPD exited with the following assertion error:

#0  0x00007fa1d19e4885 in raise () from /lib64/libc.so.6
#1  0x00007fa1d19e5e61 in abort () from /lib64/libc.so.6
#2  0x00007fa1d19dd740 in __assert_fail () from /lib64/libc.so.6
#3  0x0000000000449c17 in slap_send_ldap_result (op=0x1870000, rs=0x7fa17c742930) at result.c:830
#4  0x00000000004b6a53 in meta_back_search (op=0x1870000, rs=0x7fa17c742930) at search.c:1183
#5  0x000000000043aef1 in fe_op_search (op=0x1870000, rs=0x7fa17c742930) at search.c:402
#6  0x00000000004a1a62 in overlay_op_walk (op=0x1870000, rs=0x7fa17c742930, which=op_search, oi=0x88583c0, on=0x0) at backover.c:677
#7  0x00000000004a24dc in over_op_func (op=0x1870000, rs=0x8, which=op_add) at backover.c:730
#8  0x000000000043b73c in do_search (op=0x1870000, rs=0x7fa17c742930) at search.c:247
#9  0x00000000004382af in connection_operation (ctx=0x7fa17c742b30, arg_v=<optimized out>) at connection.c:1316
#10 0x0000000000438edb in connection_read_thread (ctx=0x7fa17c742b30, argv=<optimized out>) at connection.c:1452
#11 0x00000000004f06a0 in ldap_int_thread_pool_wrapper (xpool=<optimized out>) at tpool.c:696
#12 0x00007fa1d1d35806 in start_thread () from /lib64/libpthread.so.0
#13 0x00007fa1d1a9065d in clone () from /lib64/libc.so.6
#14 0x0000000000000000 in ?? ()

This happened because meta used to directly return the ldap_sasl_bind return value to the client, and in this case it is not an LDAP error.
We fixed the issue by mapping it to an LDAP error.

Nadezhda Ivanova

Software Engineer
Symas Corporation                       http://www.symas.com