Re: (ITS#8866) RFE: slapo-unique to return filter used in diagnostic message

[michael@stroeder.com]

On 10/26/18 4:01 AM, Quanah Gibson-Mount wrote:
> --On Monday, July 30, 2018 6:58 PM +0000 michael@stroeder.com wrote:
> 
>> Can someone correct the subject line of the ticket?
>>
>> Should of course mention slapo-unique instead of slapo-constraint.
> 
> This patch has been applied to OpenLDAP HEAD with a correction to the
> memory allocation functions.  I'll discuss with Howard about whether or
> not to add it to 2.4.47.

With your memory allocation correction, op->o_tmpalloc() and
op->o_tmpfree(), this does not work as expected with 2.4.x. It does
*not* return the filter used for uniqueness check.
(I did not test master yet.)

Example for expected diagnostic message (with my original patch applied
to 2.4.46):

   non-unique attributes found with (|(gidNumber=30041))

Result with patch backported from git master using op->o_tmpalloc() and
op->o_tmpfree():

   non-unique attributes found with non-unique attribute
                                    ^^^^^^^^^^^^^^^^^^^^
                        Seems to repeat parts of the buffer?

In my original patch the use of ch_malloc() and ch_free() was simply
copied from other overlay code. There are many occurences of ch_malloc()
and ch_free() throughout the whole code.

Does op->o_tmpalloc() and op->o_tmpfree() work correctly in RE24 branch?

Ciao, Michael.