[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8830) build hardcodes gcc

vcunat@gmail.com wrote:
> Full_Name: Vladim.r Čun.t
> Version: 0.9.22 (lmdb)
> OS: Linux (NixOS)
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (178.255.168.34)
>=20
>=20
> Some parts of the LMDB Makefile hardcode gcc, seemingly unnecessarily. =
 Please
> apply the following patch or some similar fix.

The coverage flags have only been tested with gcc. What compiler are you =
using=20
that also provides code coverage with these flags?
>=20
> commit 029031a68873bc3784a8561bd8e049efbd34f9d0 (HEAD)
> Author: Vladim=C3=ADr &#268;un=C3=A1t <vcunat@gmail.com>
> Date:   Sun Apr 1 11:05:31 2018 +0200
>=20
>      make: gcc -> $(CC)
>=20
> diff --git a/libraries/liblmdb/Makefile b/libraries/liblmdb/Makefile
> index f254511..612484e 100644
> --- a/libraries/liblmdb/Makefile
> +++ b/libraries/liblmdb/Makefile
> @@ -102,13 +102,13 @@ COV_OBJS=3Dxmdb.o xmidl.o
>  =20
>   coverage: xmtest
>   	for i in mtest*.c [0-9]*.c; do j=3D`basename \$$i .c`; $(MAKE) $$j.o=
; \
> -		gcc -o x$$j $$j.o $(COV_OBJS) -pthread $(COV_FLAGS); \
> +		$(CC) -o x$$j $$j.o $(COV_OBJS) -pthread $(COV_FLAGS); \
>   		rm -rf testdb; mkdir testdb; ./x$$j; done
>   	gcov xmdb.c
>   	gcov xmidl.c
>  =20
>   xmtest:	mtest.o xmdb.o xmidl.o
> -	gcc -o xmtest mtest.o xmdb.o xmidl.o -pthread $(COV_FLAGS)
> +	$(CC) -o xmtest mtest.o xmdb.o xmidl.o -pthread $(COV_FLAGS)
>  =20
>   xmdb.o: mdb.c lmdb.h midl.h
>   	$(CC) $(CFLAGS) -fPIC $(CPPFLAGS) -O0 $(COV_FLAGS) -c mdb.c -o $@
>=20
>=20


--=20
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/