Re: (ITS#8707) slapd: Add systemd service notification support

[fumiyas@osstech.co.jp]

On Sat, 12 Aug 2017 02:58:20 +0900,
Ryan Tandy wrote:
> > I've added slapd.service file. Please check.
> 
> Looks good to me. Thanks again for working on this! :)
> 
> Just minor comments:
> 
> > -		$(srcdir)/slapd.conf > slapd.conf.tmp ; \
> > +		$(srcdir)/slapd.conf > slapd.conf.tmp || exit $$?; \
> 
> > -		$(srcdir)/slapd.ldif > slapd.ldif.tmp ; \
> > +		$(srcdir)/slapd.ldif > slapd.ldif.tmp || exit $$?
> 
> Is there any difference between this and using && instead of ;? (Not asking for any change, I just want to make sure I understand.)

In Makefile, /bin/sh is invoked without -e option.

> > +	if test -n "$(systemdsystemunitdir)"; then \
> 
> This is echoed while the rest aren't; maybe it could be either appended to the above command, or change to @if.

Fixed. Thanks!

-- 
-- Name: SATOH Fumiyasu @ OSS Technology Corp. (fumiyas @ osstech co jp)
-- Business Home: http://www.OSSTech.co.jp/
-- GitHub Home: https://GitHub.com/fumiyas/
-- PGP Fingerprint: BBE1 A1C9 525A 292E 6729  CDEC ADC2 9DCA 5E1C CBCA