RE: (ITS#8609) segfault in mods.c - modify_add_values

[quanah@symas.com]

--On Friday, March 24, 2017 8:07 PM +0000 henson@acm.org wrote:

>> From: Ond=C5=99ej Kuzn=C3=ADk
>> Sent: Friday, March 24, 2017 2:28 AM
>> =20
>> Looks like your patch differs from what was applied to re24 at least =
> on
>> that line (which calls be_add instead). Do you know why that is? Could
>> you try with the current re24 branch (OPENLDAP_REL_ENG_2_4) instead?
>
> Ah, more confusion, sorry; I confirmed with Quanah the ITS 8432 patch I =
> applied is identical to the one applied upstream, however, the line I =
> referred to is in the patch applied to 2.4.44 release code, whereas I =
> see you are referring to the current head of the 2.4 branch, which I'm =
> sure has had numerous other changes applied to it that have probably =
> shuffled things around a bit.
>
> If I could reliably reproduce this issue :(, I would definitely test it =
> on our dev systems with whatever code you requested. Unfortunately, it =
> only randomly occurs every 2-4 weeks in production, and I don't think I =
> could get management approval to run the unreleased development branch =
> of code in production for that long to see what happens. The 2.4.45 =
> testing call came out last month, is there a timeline yet on getting =
> that out? I should be able to push that into production fairly soon =
> after it is released and see what happens there.

There's too many outstanding issues to release 2.4.45, including this one.

The remaining changes to syncrepl.c between 2.4.44 and current RE25 are:

<http://www.openldap.org/its/index.cgi/?findid=8435>
<http://www.openldap.org/its/index.cgi/?findid=8413>

I would consider at least the patch for ITS#8413 as mandatory as well. 
Since ITS#8435 has been around since 2.4.40, it's unlikely to be related.

<https://github.com/Zimbra/packages/blob/master/thirdparty/openldap/patches/ITS8413.patch> 
is an easy spot to grab it from.

--Quanah

--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>