[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8107) olcMemberOfDangling: error doesn't prevent adding nonexistent member to group

Adding a new group containing a nonexistent member, or or a nonexistent 
member to an existing group, triggers the following AddressSanitizer 
splat. No error when adding a valid member, or with memberof disabled.

(Line numbers from git master)

5532dc8c connection_get(11): got connid=1000
5532dc8c connection_read(11): checking for input on id=1000
ber_get_next
ber_get_next: tag 0x30 len 66 contents:
5532dc8c op tag 0x66, time 1429396620
ber_get_next
5532dc8c conn=1000 op=2 do_modify
ber_scanf fmt ({m) ber:
ber_scanf fmt ({e{m[W]}}) ber:
5532dc8c >>> dnPrettyNormal: <cn=testgroup,dc=example,dc=com>
5532dc8c <<< dnPrettyNormal: <cn=testgroup,dc=example,dc=com>, <cn=testgroup,dc=example,dc=com>
5532dc8c >>> dnPretty: <cn=dummy>
5532dc8c <<< dnPretty: <cn=dummy>
5532dc8c >>> dnNormalize: <cn=dummy>
5532dc8c <<< dnNormalize: <cn=dummy>
5532dc8c => mdb_search
5532dc8c mdb_dn2entry("cn=testgroup,dc=example,dc=com")
5532dc8c => mdb_dn2id("cn=testgroup,dc=example,dc=com")
5532dc8c <= mdb_dn2id: got id=0x3
5532dc8c => mdb_entry_decode:
5532dc8c <= mdb_entry_decode
5532dc8c send_ldap_result: conn=1000 op=2 p=3
5532dc8c mdb_dn2entry("cn=dummy")
5532dc8c => mdb_dn2id("cn=dummy")
=================================================================
==1998==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000024967 at pc 0x000000ebdb1f bp 0x7f91f2773650 sp 0x7f91f2773648
READ of size 1 at 0x602000024967 thread T2
    #0 0xebdb1e in lutil_strncopy /home/ryan/pkg/openldap/openldap/libraries/liblutil/utils.c:317:2
    #1 0xd10adb in mdb_dn2id /home/ryan/pkg/openldap/openldap/servers/slapd/back-mdb/dn2id.c:360:9
    #2 0xd0798e in mdb_dn2entry /home/ryan/pkg/openldap/openldap/servers/slapd/back-mdb/dn2entry.c:51:7
    #3 0xd4afb5 in mdb_entry_get /home/ryan/pkg/openldap/openldap/servers/slapd/back-mdb/id2entry.c:336:7
    #4 0xa8feb5 in overlay_entry_get_ov /home/ryan/pkg/openldap/openldap/servers/slapd/backover.c:376:9
    #5 0xaa6dd2 in over_entry_get_rw /home/ryan/pkg/openldap/openldap/servers/slapd/backover.c:408:9
    #6 0x6a4d9c in be_entry_get_rw /home/ryan/pkg/openldap/openldap/servers/slapd/backend.c:1436:10
    #7 0xdb6298 in memberof_op_modify /home/ryan/pkg/openldap/openldap/servers/slapd/overlays/memberof.c:892:12
    #8 0xa931bb in overlay_op_walk /home/ryan/pkg/openldap/openldap/servers/slapd/backover.c:681:9
    #9 0xaadbea in over_op_func /home/ryan/pkg/openldap/openldap/servers/slapd/backover.c:749:7
    #10 0xaa5493 in over_op_modify /home/ryan/pkg/openldap/openldap/servers/slapd/backover.c:788:9
    #11 0x7144f2 in fe_op_modify /home/ryan/pkg/openldap/openldap/servers/slapd/modify.c:303:4
    #12 0x70b08e in do_modify /home/ryan/pkg/openldap/openldap/servers/slapd/modify.c:177:15
    #13 0x609ccc in connection_operation /home/ryan/pkg/openldap/openldap/servers/slapd/connection.c:1134:7
    #14 0x602ec3 in connection_read_thread /home/ryan/pkg/openldap/openldap/servers/slapd/connection.c:1280:14
    #15 0xf094de in ldap_int_thread_pool_wrapper /home/ryan/pkg/openldap/openldap/libraries/libldap_r/tpool.c:958:3
    #16 0x7f91fc2f40a3 in start_thread /build/glibc-Ir_s5K/glibc-2.19/nptl/pthread_create.c:309
    #17 0x7f91fb70604c in clone /build/glibc-Ir_s5K/glibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111

0x602000024967 is located 9 bytes to the left of 10-byte region [0x602000024970,0x60200002497a)
allocated by thread T2 here:
    #0 0x4bb46b in malloc (/usr/local/libexec/slapd+0x4bb46b)
    #1 0x10e4d7f in ber_memalloc_x /home/ryan/pkg/openldap/openldap/libraries/liblber/memory.c:228:9
    #2 0xfc01e1 in ldap_dn2bv_x /home/ryan/pkg/openldap/openldap/libraries/libldap_r/getdn.c:3015:23
    #3 0x6e7a37 in dnNormalize /home/ryan/pkg/openldap/openldap/servers/slapd/dn.c:454:8
    #4 0x744d1d in ordered_value_normalize /home/ryan/pkg/openldap/openldap/servers/slapd/value.c:587:7
    #5 0x7106cd in slap_mods_check /home/ryan/pkg/openldap/openldap/servers/slapd/modify.c:627:11
    #6 0x70aca3 in do_modify /home/ryan/pkg/openldap/openldap/servers/slapd/modify.c:168:15
    #7 0x609ccc in connection_operation /home/ryan/pkg/openldap/openldap/servers/slapd/connection.c:1134:7
    #8 0x602ec3 in connection_read_thread /home/ryan/pkg/openldap/openldap/servers/slapd/connection.c:1280:14
    #9 0xf094de in ldap_int_thread_pool_wrapper /home/ryan/pkg/openldap/openldap/libraries/libldap_r/tpool.c:958:3
    #10 0x7f91fc2f40a3 in start_thread /build/glibc-Ir_s5K/glibc-2.19/nptl/pthread_create.c:309

Thread T2 created by T1 here:
    #0 0x4a309f in __interceptor_pthread_create (/usr/local/libexec/slapd+0x4a309f)
    #1 0xf1d269 in ldap_pvt_thread_create /home/ryan/pkg/openldap/openldap/libraries/libldap_r/thr_posix.c:165:8
    #2 0xf05f35 in ldap_pvt_thread_pool_submit /home/ryan/pkg/openldap/openldap/libraries/libldap_r/tpool.c:420:12
    #3 0x5e92a5 in slap_listener_activate /home/ryan/pkg/openldap/openldap/servers/slapd/daemon.c:2097:7
    #4 0x5e17a4 in slapd_daemon_task /home/ryan/pkg/openldap/openldap/servers/slapd/daemon.c:2728:10
    #5 0x7f91fc2f40a3 in start_thread /build/glibc-Ir_s5K/glibc-2.19/nptl/pthread_create.c:309

Thread T1 created by T0 here:
    #0 0x4a309f in __interceptor_pthread_create (/usr/local/libexec/slapd+0x4a309f)
    #1 0xf1d269 in ldap_pvt_thread_create /home/ryan/pkg/openldap/openldap/libraries/libldap_r/thr_posix.c:165:8
    #2 0x5d2539 in slapd_daemon /home/ryan/pkg/openldap/openldap/servers/slapd/daemon.c:2898:8
    #3 0x4e2e3e in main /home/ryan/pkg/openldap/openldap/servers/slapd/main.c:1018:7
    #4 0x7f91fb641b44 in __libc_start_main /build/glibc-Ir_s5K/glibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/ryan/pkg/openldap/openldap/libraries/liblutil/utils.c:317 lutil_strncopy
Shadow bytes around the buggy address:
  0x0c047fffc8d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fffc8e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fffc8f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fffc900: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fffc910: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c047fffc920: fa fa fa fa fa fa fa fa fa fa fa fa[fa]fa 00 02
  0x0c047fffc930: fa fa fd fd fa fa fd fd fa fa fd fa fa fa 00 02
  0x0c047fffc940: fa fa fd fd fa fa fd fa fa fa fd fd fa fa fd fd
  0x0c047fffc950: fa fa fd fa fa fa fd fd fa fa fd fa fa fa fd fa
  0x0c047fffc960: fa fa fd fd fa fa fd fa fa fa fd fa fa fa fd fa
  0x0c047fffc970: fa fa fd fa fa fa fd fa fa fa fd fd fa fa fd fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  ASan internal:           fe
==1998==ABORTING