[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#8054) Operation duration logging

michael@stroeder.com wrote:
> ebackes@symas.com wrote:
>> Here is a patch to add duration logging for operations that appears in the
>> standard result messages of statslog.  It's a reasonably small change with
>> negligible performance implications except under pathological benchmarking
>> conditions.  It does change the quasi-machine-parsable statslog format, however,
>> so it might not be appropriate for general 2.4 release.  Example line:
>> 54d8298c conn=1000 op=1 SEARCH RESULT tag=101 err=0 duration=0.170ms nentries=1
>> text=
> This is a very important feature. Highly appreciated!
> I'd love to see this in RE24. Yes, I know. No more features. :-(
> Would it be possible and make sense to have this configurable per database?

No it would not make sense. There are ops like Abandon and Unbind which 
have no associated database.

Adding variation here is creating gratuitous complexity for no benefit.
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/